Fix issues with copying worksheets across workbooks (#839)
* Tests for copying worksheets added

* Add tests for pictures and data validation rules

* Fix test for styles copying

* Extract copying logic into dedicated classes (XLPicture, XLTable, XLNamedRange). Implement copying of conditional formats.

* Implement failing scenario for existing test

* Fixed copying conditional formats

* Fixed copying of merged ranges

* Tests simplified as saving issues must be addressed separately

* Fixed saving the row heights on copied worksheets

* Add tests for copying tables and selected ranges. Fix copying selected ranges.

* Fix copying page setup

* Removed debugging code

* CopyTo and WithoutWorksheet method removed from public API. A new constructor for XLConditionalFormat added. Formatting issues fixed.

* Copying table with or without data implemented. Tests added.

* Revert removing public methods

* Copying pictures within a worksheet implemented. Tests added.

* Tests for named ranges copying added.

* Implement XLPicture.Duplicate method.

* Update doctext

* Fix IXLPicture.CopyTo signature
1 parent 52421d6 commit e4c040d98990b42b0d821c4276f0f60fafa0c1fb
@Aleksei Aleksei authored on 11 May 2018
Francois Botha committed on 11 May 2018
Showing 21 changed files
View
ClosedXML/Excel/Cells/XLCell.cs
View
ClosedXML/Excel/ConditionalFormats/IXLConditionalFormat.cs
View
ClosedXML/Excel/ConditionalFormats/XLConditionalFormat.cs
View
ClosedXML/Excel/Coordinates/XLAddress.cs
View
ClosedXML/Excel/Drawings/IXLPicture.cs
View
ClosedXML/Excel/Drawings/XLPicture.cs
View
ClosedXML/Excel/NamedRanges/IXLNamedRange.cs
View
ClosedXML/Excel/NamedRanges/XLNamedRange.cs
View
ClosedXML/Excel/PageSetup/XLPageSetup.cs
View
ClosedXML/Excel/Ranges/XLRangeAddress.cs
View
ClosedXML/Excel/Ranges/XLRangeBase.cs
View
ClosedXML/Excel/Rows/XLRow.cs
View
ClosedXML/Excel/Tables/IXLTable.cs
View
ClosedXML/Excel/Tables/XLTable.cs
View
ClosedXML/Excel/XLWorksheet.cs
View
ClosedXML_Tests/Excel/ConditionalFormats/ConditionalFormatCopyTests.cs
View
ClosedXML_Tests/Excel/ImageHandling/PictureTests.cs
View
ClosedXML_Tests/Excel/NamedRanges/NamedRangesTests.cs
View
ClosedXML_Tests/Excel/Saving/SavingTests.cs
View
ClosedXML_Tests/Excel/Tables/TablesTests.cs
View
ClosedXML_Tests/Excel/Worksheets/XLWorksheetTests.cs