Fix XLColor equals method (#25)

Fork: 0

knarita / ClosedXML

Browse code Fix XLColor equals method (#25) * Use ToArgb() to compare equality of colors, in order to return TRUE when comparing RGB(FF,FF,FF) to White. http://stackoverflow.com/questions/8146453/system-drawing-color-equality-operator-doesnt-treat-0xffffffff-as-color-white * Add test for named color vs RGB * Update bespoke unit tests files to remove duplicate font styles. * Set substringo of rich text to Garamond font, instead of Broadway. Broadway probably isn't installed on the AppVeyor server. Garamond is a much more common pre-installed font. * Disable different font to see if it affects the AppVeyor build. * Use Courier font for rich text. Hopefully this one is installed on AppVeyor. develop master open_document_problem release-candidate 0.93.1 0.93.0-rc3 0.93.0-rc2 0.93.0-rc1 0.93.0-beta4 0.93.0-beta1 0.93.0 0.92.0-beta1 0.92.0 0.91.1 0.91.0-beta3 0.91.0-beta1 0.91.0 0.90.0-beta2 0.90.0 0.89.0-beta1 0.89.0 0.88.0-beta1 0.88.0 0.87.1 0.87.0 0.86.0 0.85.0 0.80.1
1 parent be46d1e commit 9f70f62d7dece4a4527bc6c2411b69df507ca51c Francois Botha authored on 14 Sep 2016 Amir committed on 14 Sep 2016

Browse code

* Use ToArgb() to compare equality of colors, in order to return TRUE when comparing RGB(FF,FF,FF) to White.
http://stackoverflow.com/questions/8146453/system-drawing-color-equality-operator-doesnt-treat-0xffffffff-as-color-white

* Add test for named color vs RGB

* Update bespoke unit tests files to remove duplicate font styles.

* Set substringo of rich text to Garamond font, instead of Broadway. Broadway probably isn't installed on the AppVeyor server. Garamond is a much more common pre-installed font.

* Disable different font to see if it affects the AppVeyor build.

* Use Courier font for rich text. Hopefully this one is installed on AppVeyor.

develop master open_document_problem release-candidate 0.93.1 0.93.0-rc3 0.93.0-rc2 0.93.0-rc1 0.93.0-beta4 0.93.0-beta1 0.93.0 0.92.0-beta1 0.92.0 0.91.1 0.91.0-beta3 0.91.0-beta1 0.91.0 0.90.0-beta2 0.90.0 0.89.0-beta1 0.89.0 0.88.0-beta1 0.88.0 0.87.1 0.87.0 0.86.0 0.85.0 0.80.1

1 parent be46d1e commit 9f70f62d7dece4a4527bc6c2411b69df507ca51c

Francois Botha authored on 14 Sep 2016

Amir committed on 14 Sep 2016

Patch

Unified Split

Showing 96 changed files

Ignore Space Show notes View ClosedXML/Excel/Style/Colors/XLColor_Public.cs

Ignore Space Show notes View ClosedXML_Examples/Styles/UsingRichText.cs

Ignore Space Show notes View ClosedXML_Tests/Excel/Styles/ColorTests.cs

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/AutoFilter/CustomAutoFilter.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/AutoFilter/DynamicAutoFilter.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/AutoFilter/RegularAutoFilter.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/AutoFilter/TopBottomAutoFilter.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Columns/ColumnCells.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Columns/ColumnCollection.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Columns/ColumnSettings.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Columns/DeletingColumns.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Comments/AddingComments.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFColorScaleLowHigh.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFColorScaleLowMidHigh.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFContains.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFDataBar.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFEndsWith.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFEqualsNumber.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFEqualsString.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFIconSet.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFIsBlank.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFIsError.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFNotBlank.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFNotContains.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFNotEqualsNumber.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFNotEqualsString.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFNotError.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/ConditionalFormatting/CFStartsWith.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Delete/DeleteFewWorksheets.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Delete/RemoveRows.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Loading/ChangingBasicTable.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/AddingDataSet.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/AddingDataTableAsWorksheet.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/AdjustToContents.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/AutoFilter.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/BasicTable.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/BlankCells.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/CellValues.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/Collections.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/CopyingRowsAndColumns.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/CopyingWorksheets.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/DataTypes.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/DataValidation.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/Formulas.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/FreezePanes.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/HideSheets.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/HideUnhide.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/Hyperlinks.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/InsertingData.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/InsertingTables.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/LambdaExpressions.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/MergeCells.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/MergeMoves.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/Outline.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/SheetProtection.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/ShiftingFormulas.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/ShowCase.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/TabColors.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Misc/WorkbookProperties.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/PageSetup/HeaderFooters.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/PageSetup/Margins.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/PageSetup/Page.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/PageSetup/SheetTab.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/PageSetup/Sheets.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/PageSetup/TwoPages.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/ClearingRanges.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/CopyingRanges.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/CurrentRowColumn.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/DefiningRanges.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/DeletingRanges.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/InsertingDeletingColumns.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/InsertingDeletingRows.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/MultipleRanges.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/NamedRanges.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/SelectingRanges.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/ShiftingRanges.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/SortExample.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/Sorting.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/TransposeRanges.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/TransposeRangesPlus.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/UsingTables.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Ranges/WalkingRanges.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Rows/RowCells.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Rows/RowCollection.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Rows/RowSettings.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Styles/DefaultStyles.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Styles/PurpleWorksheet.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Styles/StyleAlignment.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Styles/StyleBorder.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Styles/StyleFill.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Styles/StyleFont.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Styles/StyleNumberFormat.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Styles/StyleRowsColumns.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Styles/StyleWorksheet.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Styles/UsingColors.xlsx
Not supported

Ignore Space Show notes View ClosedXML_Tests/Resource/Examples/Styles/UsingRichText.xlsx
Not supported

Show line notes below